Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The builder should ignore 'part of' files #115

Closed
natebosch opened this issue Dec 13, 2016 · 1 comment
Closed

The builder should ignore 'part of' files #115

natebosch opened this issue Dec 13, 2016 · 1 comment
Assignees
@natebosch

Comments

@natebosch
Copy link
Member

If bar.dart is a part of another file it doesn't make sense to create bar.g.dart. I think we can recurse into libraries and treat every Element in bar.dart as if it was in the library foo.dart
@natebosch natebosch self-assigned this Dec 13, 2016
@natebosch natebosch mentioned this issue Dec 13, 2016
Closed
@alorenzen
Copy link
Contributor

This is blocking angulardart/angular#48

This was referenced Jan 10, 2017
Merged
Merged
natebosch added a commit to dart-archive/code_transformers that referenced this issue Jan 10, 2017
@natebosch
Avoid LibraryElement instances for part files (#53)
e7583dc 
If we pass a Source representing a 'part of' file to the analysis
context it will create a LibraryElement which is not sensible. We should
only create a LibraryElement when the Source represents a library.

Fixes dart-lang/source_gen#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natebosch natebosch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alorenzen @natebosch