Read parts with the defining compilation unit #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The direct read of the imports, exports, and parts from the library element is deprecated. Unblocks https://dart-review.googlesource.com/c/sdk/+/388643
|
It actually sounds like these are getting undeprecated... https://dart-review.googlesource.com/c/sdk/+/389142 |
scheglov
approved these changes
Oct 10, 2024
natebosch
changed the title
scheglov
reviewed
Oct 11, 2024
| @@ -41,8 +41,7 @@ class LibraryReader { | |||
| ...element.libraryImports, | |||
There was a problem hiding this comment.
I'm sorry, I failed to look precisely at it.
In analyzer 6.11 we un-deprecate LibraryElement.importedLibraries, not libraryImports.
So, these still should be migrated, like parts below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The direct read of parts from the library element is deprecated.
Retain ignores for reading imports and exports since they
will be restored without a deprecation.
Unblocks https://dart-review.googlesource.com/c/sdk/+/388643