enable windows for the unit_tests in the test package

pkgs/test/dart_test.yaml

@@ -30,7 +30,9 @@ tags:
     add_tags: [browser]
     timeout: 2x
 
-  firefox: {add_tags: [dart2js]}
+  firefox:
+    add_tags: [dart2js]
+    test_on: linux
   chrome: {add_tags: [dart2js]}
 
   safari:
@@ -40,6 +42,7 @@ tags:
   ie:
     add_tags: [dart2js]
     test_on: windows
+    skip: https://github.com/dart-lang/test/issues/1614
 
   # Tests that run pub. These tests may need to be excluded when there are local
   # dependency_overrides.
@@ -50,3 +53,4 @@ tags:
   # don't have Node installed.
   node:
     timeout: 2x
+    test_on: linux

pkgs/test/mono_pkg.yaml

@@ -9,9 +9,36 @@ stages:
         - analyze: --fatal-infos
         dart:
         - dev
+        os:
+        - linux
     - unit_test:
       - command: xvfb-run -s "-screen 0 1024x768x24" dart test --preset travis --total-shards 5 --shard-index 0
       - command: xvfb-run -s "-screen 0 1024x768x24" dart test --preset travis --total-shards 5 --shard-index 1
       - command: xvfb-run -s "-screen 0 1024x768x24" dart test --preset travis --total-shards 5 --shard-index 2
       - command: xvfb-run -s "-screen 0 1024x768x24" dart test --preset travis --total-shards 5 --shard-index 3
       - command: xvfb-run -s "-screen 0 1024x768x24" dart test --preset travis --total-shards 5 --shard-index 4
+      - command: dart test --preset travis --total-shards 5 --shard-index 0
+        os:
+        - windows
+        dart:
+        - stable
+      - command: dart test --preset travis --total-shards 5 --shard-index 1
+        os:
+        - windows
+        dart:
+        - stable
+      - command: dart test --preset travis --total-shards 5 --shard-index 2
+        os:
+        - windows
+        dart:
+        - stable
+      - command: dart test --preset travis --total-shards 5 --shard-index 3
+        os:
+        - windows
+        dart:
+        - stable
+      - command: dart test --preset travis --total-shards 5 --shard-index 4
+        os:
+        - windows
+        dart:
+        - stable

pkgs/test/test/io.dart

@@ -17,7 +17,8 @@ final Future<String> packageDir =
     Isolate.resolvePackageUri(Uri(scheme: 'package', path: 'test/'))
         .then((uri) {
   var dir = p.dirname(uri!.path);
-  if (dir.startsWith('/C:')) dir = dir.substring(1);
+  // If it starts with a `/C:` or other drive letter, remove the leading `/`.
+  if (dir[0] == '/' && dir[2] == ':') dir = dir.substring(1);
   return dir;
 });
 

pkgs/test/test/runner/configuration/platform_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 import 'dart:convert';
+import 'dart:io';
 
 import 'package:test_descriptor/test_descriptor.dart' as d;
 
@@ -205,8 +206,10 @@ void main() {
       var test = await runTest(['.']);
       expect(
           test.stdout,
-          containsInOrder(
-              ['+0: ./test_foo.dart: test_foo', '+1: All tests passed!']));
+          containsInOrder([
+            '+0: .${Platform.pathSeparator}test_foo.dart: test_foo',
+            '+1: All tests passed!'
+          ]));
       await test.shouldExit(0);
     });
 
@@ -241,8 +244,10 @@ void main() {
       var test = await runTest(['.']);
       expect(
           test.stdout,
-          containsInOrder(
-              ['+0: ./foo_test.dart: foo_test', '+1: All tests passed!']));
+          containsInOrder([
+            '+0: .${Platform.pathSeparator}foo_test.dart: foo_test',
+            '+1: All tests passed!'
+          ]));
       await test.shouldExit(0);
     });
 

pkgs/test/test/runner/configuration/randomize_order_test.dart

@@ -4,6 +4,7 @@
 
 @TestOn('vm')
 import 'dart:convert';
+import 'dart:io';
 
 import 'package:test_descriptor/test_descriptor.dart' as d;
 
@@ -148,14 +149,14 @@ void main() {
         test.stdout,
         emitsInAnyOrder([
           containsInOrder([
-            './1_test.dart: test 1.2',
-            './1_test.dart: test 1.3',
-            './1_test.dart: test 1.1'
+            '.${Platform.pathSeparator}1_test.dart: test 1.2',
+            '.${Platform.pathSeparator}1_test.dart: test 1.3',
+            '.${Platform.pathSeparator}1_test.dart: test 1.1'
           ]),
           containsInOrder([
-            './2_test.dart: test 2.2',
-            './2_test.dart: test 2.3',
-            './2_test.dart: test 2.1'
+            '.${Platform.pathSeparator}2_test.dart: test 2.2',
+            '.${Platform.pathSeparator}2_test.dart: test 2.3',
+            '.${Platform.pathSeparator}2_test.dart: test 2.1'
           ]),
           contains('+6: All tests passed!')
         ]));

pkgs/test/test/runner/configuration/top_level_test.dart

@@ -98,7 +98,9 @@ void main() {
     await expectLater(
         test.stdout, emitsThrough(contains('+1: All tests passed!')));
     await test.shouldExit(0);
-  }, tags: 'chrome');
+  }, tags: 'chrome', onPlatform: const {
+    'windows': Skip('https://github.com/dart-lang/test/issues/1613')
+  });
 
   test('runs skipped tests with run_skipped: true', () async {
     await d.file('dart_test.yaml', jsonEncode({'run_skipped': true})).create();

pkgs/test/test/runner/hybrid_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn('vm')
+@OnPlatform({'windows': Skip('https://github.com/dart-lang/test/issues/1618')})
 
 import 'dart:io';
 import 'dart:isolate';
@@ -90,7 +91,7 @@ void main() {
 
               void hybridMain(StreamChannel channel) {
                 channel.sink
-                  ..add(File("$path").readAsStringSync())
+                  ..add(File(r"$path").readAsStringSync())
                   ..close();
               }
             """).stream.first, completion(contains("hybrid emits numbers")));

pkgs/test/test/runner/name_test.dart

@@ -294,7 +294,7 @@ void main() {
 
     var test = await runTest(['test.dart?name=selected&full-name=selected 1']);
 
-    await test.shouldExit(255);
+    await test.shouldExit(64);
   });
 
   group('with the --name flag,', () {

pkgs/test/test/runner/pause_after_load_test.dart

@@ -3,6 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn('vm')
+@OnPlatform({'windows': Skip('https://github.com/dart-lang/test/issues/1613')})
 
 import 'dart:async';
 import 'dart:io';

pkgs/test/test/runner/precompiled_test.dart

@@ -3,6 +3,8 @@
 // BSD-style license that can be found in the LICENSE file.
 
 @TestOn('vm')
+@OnPlatform({'windows': Skip('https://github.com/dart-lang/test/issues/1617')})
+
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
@@ -13,7 +15,6 @@ import 'package:path/path.dart' as p;
 import 'package:test_descriptor/test_descriptor.dart' as d;
 import 'package:test_process/test_process.dart';
 
-import 'package:test_core/src/util/io.dart';
 import 'package:test/test.dart';
 import 'package:test/src/util/package_map.dart';
 
@@ -46,10 +47,12 @@ void main() {
       ]).create();
 
       var dart2js = await TestProcess.start(
-          p.join(sdkDir, 'bin', 'dart2js'),
+          Platform.resolvedExecutable,
           [
+            'compile',
+            'js',
             ...Platform.executableArguments,
-            '--packages=${await Isolate.packageConfig}',
+            '--packages=${(await Isolate.packageConfig)!.toFilePath()}',
             'to_precompile.dart',
             '--out=precompiled/test.dart.browser_test.dart.js'
           ],
@@ -104,9 +107,10 @@ void main() {
 
       var jsPath = p.join(d.sandbox, 'test', 'test.dart.node_test.dart.js');
       var dart2js = await TestProcess.start(
-          p.join(sdkDir, 'bin', 'dart2js'),
+          Platform.resolvedExecutable,
           [
-            ...Platform.executableArguments,
+            'compile',
+            'js',
             '--packages=${await Isolate.packageConfig}',
             p.join('test', 'test.dart'),
             '--out=$jsPath',

pkgs/test/test/runner/runner_test.dart

@@ -740,6 +740,8 @@ void main(List<String> args) async {
           ])));
       await test.shouldExit(0);
     });
+  }, onPlatform: const {
+    'windows': Skip('https://github.com/dart-lang/test/issues/1615')
   });
 
   group('nnbd', () {

pkgs/test/test/runner/shard_test.dart

@@ -4,6 +4,8 @@
 
 @TestOn('vm')
 
+import 'dart:io';
+
 import 'package:test_descriptor/test_descriptor.dart' as d;
 
 import 'package:test_core/src/util/exit_codes.dart' as exit_codes;
@@ -94,10 +96,14 @@ void main() {
         test.stdout,
         emitsInOrder([
           emitsAnyOf([
-            containsInOrder(
-                ['+0: ./1_test.dart: test 1.1', '+1: ./2_test.dart: test 2.1']),
-            containsInOrder(
-                ['+0: ./2_test.dart: test 2.1', '+1: ./1_test.dart: test 1.1'])
+            containsInOrder([
+              '+0: .${Platform.pathSeparator}1_test.dart: test 1.1',
+              '+1: .${Platform.pathSeparator}2_test.dart: test 2.1'
+            ]),
+            containsInOrder([
+              '+0: .${Platform.pathSeparator}2_test.dart: test 2.1',
+              '+1: .${Platform.pathSeparator}1_test.dart: test 1.1'
+            ])
           ]),
           contains('+2: All tests passed!')
         ]));
@@ -108,10 +114,14 @@ void main() {
         test.stdout,
         emitsInOrder([
           emitsAnyOf([
-            containsInOrder(
-                ['+0: ./1_test.dart: test 1.2', '+1: ./2_test.dart: test 2.2']),
-            containsInOrder(
-                ['+0: ./2_test.dart: test 2.2', '+1: ./1_test.dart: test 1.2'])
+            containsInOrder([
+              '+0: .${Platform.pathSeparator}1_test.dart: test 1.2',
+              '+1: .${Platform.pathSeparator}2_test.dart: test 2.2'
+            ]),
+            containsInOrder([
+              '+0: .${Platform.pathSeparator}2_test.dart: test 2.2',
+              '+1: .${Platform.pathSeparator}1_test.dart: test 1.2'
+            ])
           ]),
           contains('+2: All tests passed!')
         ]));
@@ -122,10 +132,14 @@ void main() {
         test.stdout,
         emitsInOrder([
           emitsAnyOf([
-            containsInOrder(
-                ['+0: ./1_test.dart: test 1.3', '+1: ./2_test.dart: test 2.3']),
-            containsInOrder(
-                ['+0: ./2_test.dart: test 2.3', '+1: ./1_test.dart: test 1.3'])
+            containsInOrder([
+              '+0: .${Platform.pathSeparator}1_test.dart: test 1.3',
+              '+1: .${Platform.pathSeparator}2_test.dart: test 2.3'
+            ]),
+            containsInOrder([
+              '+0: .${Platform.pathSeparator}2_test.dart: test 2.3',
+              '+1: .${Platform.pathSeparator}1_test.dart: test 1.3'
+            ])
           ]),
           contains('+2: All tests passed!')
         ]));