Skip to content

Don't do direct casts to int to prevent dart2wasm breakages. #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakemac53 merged 10 commits into from
May 5, 2023
Merged

Don't do direct casts to int to prevent dart2wasm breakages. #2007

jakemac53 merged 10 commits into from
May 5, 2023

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented May 4, 2023

This fixes #2006

@kevmoo kevmoo requested a review from natebosch May 4, 2023 04:42
@natebosch
Copy link
Member

natebosch commented May 4, 2023

Are there tests in this repo that will fail without this change so that we don't regress?

@jakemac53
Copy link
Contributor

jakemac53 commented May 4, 2023

Are there tests in this repo that will fail without this change so that we don't regress?

It looks like if we made a dart2wasm test that uses a timeout we could get that

@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented May 4, 2023

I'll write a test

@jakemac53
Copy link
Contributor

jakemac53 commented May 4, 2023

See https://github.com/dart-lang/test/tree/master/integration_tests/wasm which is probably the easiest place to put this test for now

eyebrowsoffire and others added 3 commits May 4, 2023 10:37
@eyebrowsoffire
Merge branch 'master' into wasm_to_int
f40fcee
@eyebrowsoffire
Have wasm unit tests pass --timeout and --retry.
39bc95a
@natebosch
Bump to -wip version in test_api
97b65ce 
Fix dependencies in test to use the latest test_core in addition to the
latest test_api
jakemac53
jakemac53 reviewed May 4, 2023
View reviewed changes
jakemac53
jakemac53 reviewed May 4, 2023
View reviewed changes
jakemac53
jakemac53 reviewed May 5, 2023
View reviewed changes
@eyebrowsoffire @jakemac53
Update integration_tests/wasm/test/hello_world_test.dart
9b61437 
Co-authored-by: Jacob MacDonald <jakemac@google.com>
@jakemac53 jakemac53 merged commit 1d65501 into dart-lang:master May 5, 2023
@jakemac53
Copy link
Contributor

jakemac53 commented May 5, 2023

@eyebrowsoffire did you need a publish of this soon? @natebosch thoughts on when we should publish?

@natebosch
Copy link
Member

natebosch commented May 5, 2023

I think I'm close to getting #2004 landable in google3 - I plan to publish after I can land that

@eyebrowsoffire
Copy link
Contributor Author

eyebrowsoffire commented May 5, 2023

We have a workaround in Flutter for now, so there's no huge rush on a publish, but let me know there is a new version and we'll bump to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

@natebosch natebosch natebosch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deserialization of timeout in suite metadata fails in dart2wasm

3 participants

@eyebrowsoffire @natebosch @jakemac53