update changelogs per https://github.com/dart-lang/test/pull/2262 #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes aren't user facing (not even to ourselves as users of the packages). I'd be inclined to skip the changelog check if it had already been enabled on that PR. I don't know if we've ever decided on concrete guidelines for when to include or omit changelog changes. Maybe we should... |
|
This is user facing - dart2wasm was broken on windows entirely afaik, and now it will work. Maybe the wording is confusing though? In other words, what changed isn't that our internal dart2wasm tests now pass, its that dart2wasm tests in general can now work on windows. |
natebosch
approved these changes
Aug 13, 2024
|
I misread the linked PR. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 19, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/ce09815..b444974): b4449742 2024-08-14 Sam Rawlins Add a doc-import into template_data.dart to resolve 'GeneratorBackend.write' (dart-lang/dartdoc#3832) 7fb1f3f3 2024-08-14 Sam Rawlins Fix links in sidebar of extension types (dart-lang/dartdoc#3831) 392e2aa3 2024-08-14 Sam Rawlins Simplify some Container fields only used for sidebar logic. (dart-lang/dartdoc#3834) 31e110d6 2024-08-13 Sam Rawlins Add tests supporting the wildcard feature (dart-lang/dartdoc#3835) ecosystem (https://github.com/dart-lang/ecosystem/compare/2719d0c..8626bff): 8626bff 2024-08-16 Jacob MacDonald More concise formatting of github workflow summary comments (dart-lang/ecosystem#288) de7883c 2024-08-14 Moritz Update PR Health install instructions (dart-lang/ecosystem#286) 03bf029 2024-08-14 Moritz Fix linting (dart-lang/ecosystem#287) http (https://github.com/dart-lang/http/compare/76512c4..b97b8dc): b97b8dc 2024-08-16 Anikate De pkgs/ok_http: OkHttpClientConfiguration and configurable timeouts. (dart-lang/http#1289) 4322382 2024-08-13 Brian Quinlan Fix "unintended_html_in_doc_comment" analysis errors (dart-lang/http#1291) test (https://github.com/dart-lang/test/compare/8be3c94..cd3dbd5): cd3dbd51 2024-08-15 Jacob MacDonald require approval from core-package-admins for anything under /pkgs (dart-lang/test#2268) cfc18ee1 2024-08-14 Jacob MacDonald add health check job (dart-lang/test#2266) f3984a72 2024-08-13 Jacob MacDonald update changelogs per dart-lang/test#2262 (dart-lang/test#2267) tools (https://github.com/dart-lang/tools/compare/d563c38..5b15f8b): 5b15f8b 2024-08-14 Nate Bosch Add examples of calling two algorithms to README (dart-lang/tools#293) ece541c 2024-08-14 Nate Bosch Ignore unintended_html_in_doc_comment (dart-lang/tools#294) Change-Id: I23d2f9606e4bfefdfa61e0a4c629f3f05f00c996 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381320 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.