Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests, travis support, some lints #12

Merged
merged 2 commits into from
Dec 8, 2017
Merged

add tests, travis support, some lints #12

merged 2 commits into from
Dec 8, 2017

Conversation

devoncarew
Copy link
Member

import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';

// ignore_for_file: always_declare_return_types
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add these return types?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the test methods? I normally see them w/o. happy w/ whichever

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@devoncarew devoncarew merged commit 1d6f3a4 into master Dec 8, 2017
@kevmoo kevmoo deleted the tests branch December 8, 2017 21:34
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
…/tests

add tests, travis support, some lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for this package?
3 participants