Add timeout support to test_reflective_loader. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use it, annotate a method with @TestTimeout(t) where t is a const instance of the Timeout class from the `test` package. E.g.: @TestTimeout(const Timeout.factor(2))
scheglov
approved these changes
Mar 26, 2018
lib/test_reflective_loader.dart
Outdated
| @@ -264,6 +274,16 @@ class ReflectiveTest { | |||
| const ReflectiveTest(); | |||
| } | |||
|
|
|||
| /** | |||
| * A marker annotation used to annotate overridden test methods with additional | |||
There was a problem hiding this comment.
Is it just for overridden test methods, or we can use this also for the declaration of test methods?
There was a problem hiding this comment.
Oops, this was a copy-paste error. Fixed.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
…/add-timeout-support Add timeout support to test_reflective_loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use it, annotate a method with @TestTimeout(t) where t is a const
instance of the Timeout class from the
testpackage. E.g.: