Rename runReflectiveTests -> defineReflectiveTests. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,13 +26,13 @@ import 'package:unittest/unittest.dart'; | |||
| * method invocation. If method returns [Future] to test some asyncronous | |||
| * behavior, then `tearDown` will be invoked in `Future.complete`. | |||
| */ | |||
| void runReflectiveTests(Type type) { | |||
| void defineReflectiveTests(Type type) { | |||
There was a problem hiding this comment.
I know I suggested defineReflectiveTests, but another name to consider would be reflectiveTests. It follows the pattern of the test library, where the methods used to define the entities have are just the name of the entity. Very passive, like group or test. So reflectiveTests would be in keeping with that.
That said, I think defineReflectiveTests or reflectiveTests is an improvement over runReflectiveTests in terms of naming what it does, so whichever you prefer.
|
lgtm; one more name to consider |
scheglov
added a commit
that referenced
this pull request
Apr 22, 2015
Rename runReflectiveTests -> defineReflectiveTests.
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 11, 2024
…rename-to-defineReflectiveTests Rename runReflectiveTests -> defineReflectiveTests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@devoncarew