Merge pull request dart-lang/test_reflective_loader#4 from dart-lang/…

…rename-to-defineReflectiveTests Rename runReflectiveTests -> defineReflectiveTests.
dart-lang · Apr 22, 2015 · 2846ea4 · 2846ea4
2 parents 117d3c0 + 76b8c75
commit 2846ea4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/pkgs/test_reflective_loader/.gitignore b/pkgs/test_reflective_loader/.gitignore
@@ -2,6 +2,7 @@
 .DS_Store
 .idea
 .pub/
+.project
 .settings/
 build/
 packages

diff --git a/pkgs/test_reflective_loader/lib/test_reflective_loader.dart b/pkgs/test_reflective_loader/lib/test_reflective_loader.dart
@@ -11,7 +11,7 @@ import 'dart:async';
 import 'package:unittest/unittest.dart';
 
 /**
- * Runs test methods existing in the given [type].
+ * Define tests using methods existing in the given [type].
  *
  * Methods with names starting with `test` are run using [test] function.
  * Methods with names starting with `solo_test` are run using [solo_test] function.
@@ -26,13 +26,13 @@ import 'package:unittest/unittest.dart';
  * method invocation. If method returns [Future] to test some asyncronous
  * behavior, then `tearDown` will be invoked in `Future.complete`.
  */
-void runReflectiveTests(Type type) {
+void defineReflectiveTests(Type type) {
   ClassMirror classMirror = reflectClass(type);
   if (!classMirror.metadata.any((InstanceMirror annotation) =>
-  annotation.type.reflectedType == ReflectiveTest)) {
+      annotation.type.reflectedType == ReflectiveTest)) {
     String name = MirrorSystem.getName(classMirror.qualifiedName);
     throw new Exception('Class $name must have annotation "@reflectiveTest" '
-    'in order to be run by runReflectiveTests.');
+        'in order to be run by runReflectiveTests.');
   }
   String className = MirrorSystem.getName(classMirror.simpleName);
   group(className, () {
@@ -102,8 +102,8 @@ Future _runFailingTest(ClassMirror classMirror, Symbol symbol) {
 _runTest(ClassMirror classMirror, Symbol symbol) {
   InstanceMirror instanceMirror = classMirror.newInstance(new Symbol(''), []);
   return _invokeSymbolIfExists(instanceMirror, #setUp)
-  .then((_) => instanceMirror.invoke(symbol, []).reflectee)
-  .whenComplete(() => _invokeSymbolIfExists(instanceMirror, #tearDown));
+      .then((_) => instanceMirror.invoke(symbol, []).reflectee)
+      .whenComplete(() => _invokeSymbolIfExists(instanceMirror, #tearDown));
 }
 
 /**

diff --git a/pkgs/test_reflective_loader/pubspec.yaml b/pkgs/test_reflective_loader/pubspec.yaml
@@ -1,5 +1,5 @@
 name: test_reflective_loader
-version: 0.0.2
+version: 0.0.3
 description: Support for discovering tests and test suites using reflection.
 author: Dart Team <misc@dartlang.org>
 homepage: https://github.com/dart-lang/test_reflective_loader