Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an implementation of transitiveClosure #104

Closed
natebosch opened this issue Dec 7, 2017 · 4 comments
Closed

Add an implementation of transitiveClosure #104

natebosch opened this issue Dec 7, 2017 · 4 comments
Labels
package:graphs type-enhancement A request for a change that isn't a bug

Comments

@natebosch
Copy link
Member

https://en.wikipedia.org/wiki/Floyd%E2%80%93Warshall_algorithm

This should let us deprecate the one in package:collection
https://www.dartdocs.org/documentation/collection/1.14.3/collection/transitiveClosure.html
@devoncarew devoncarew added the type-enhancement A request for a change that isn't a bug label May 23, 2023
@devoncarew devoncarew transferred this issue from dart-archive/graphs May 23, 2023
@freemansoft
Copy link

Does this commit on the dart-lang tools close this issue at least on the dart-lang tools side?

It added transative_closure.dart to this project.

@natebosch
Copy link
Member Author

Yes, this has been implemented.

@natebosch
Copy link
Member Author

@lrhn - any opinions on whether we should deprecate the copy of transitiveClosure with the more restrictive data model from package:collection?

@lrhn
Copy link
Member

lrhn commented Jan 12, 2024

Seems reasonable to deprecate.
The alternative is to make the existing function use the new implementation, but I don't want to add a dependency to package:collection.
If so, we should do so soon, so we can remove in next major version.

natebosch added a commit to dart-archive/collection that referenced this issue Feb 13, 2024
@natebosch
Deprecate transitiveClosure
c3cf561 
The algorithm is implemented with a more flexible signature in
`package:graphs`.
See dart-lang/tools#104

Use an `ignore_for_file` rather than comment each usage of the
deprecated APIs.
@natebosch natebosch mentioned this issue Feb 13, 2024
Merged
kevmoo pushed a commit to dart-archive/collection that referenced this issue Jun 7, 2024
@natebosch
Deprecate transitiveClosure (#336)
9e441f1 
The algorithm is implemented with a more flexible signature in
`package:graphs`.
See dart-lang/tools#104

Use an `ignore_for_file` rather than comment each usage of the
deprecated APIs.
mosuem pushed a commit that referenced this issue Aug 13, 2024
@natebosch
Fix lint await_only_futures (#104)
dd5f6a1
mosuem pushed a commit to dart-lang/core that referenced this issue Oct 18, 2024
@natebosch
Deprecate transitiveClosure (dart-archive/collection#336)
2193df6 
The algorithm is implemented with a more flexible signature in
`package:graphs`.
See dart-lang/tools#104

Use an `ignore_for_file` rather than comment each usage of the
deprecated APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:graphs type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@freemansoft @devoncarew @lrhn @natebosch