Pass test locations to test/groups

[DanTup]

pkg:test provides the locations of tests in the JSON reporter. We use these in VS Code to provide navigation to tests (and VS Code also shows failure messages inline against those tests).

Those locations are computed by pkg:test by looking at the call stack when group() and test() are called, and then walking up to the first frame from the suite file. For test_reflective_loader this results in all tests being attributed to the calls to defineReflectiveSuite().

I've made a change to pkg:test to support passing custom locations to test/group. Once that's released, pkg:test_reflective_loader can be updated to provide those locations when it calls group/test.

I'm happy to make this change once pkg:test rolls out, I'm just recording the issue here in the meantime.

Related:

• Dart SDK tests command to "Go to test" doesn't work as expected Dart-Code/Dart-Code#5480 - original Dart-Code issue
• Test line/col/filenames are incorrect when using package:test_reflective_loader test#2029 - related pkg:test issue
• Allow specifying an explicit location for test/groups test#2481 - change to pkg:test to support custom test locations

[FMorschel]

once pkg:test rolls out

Do we have a timeline for this release? I'm not trying to rush anyone here, just trying to understand if we have this information anywhere.

[DanTup]

Releases were published a short while ago :-)

dart-lang/test#2495
https://pub.dev/packages/test

I haven't started on the pkg:test_reflective_loader changes yet, but I don't expect them to take long so may get to them this week.

[DanTup]

I've opened a PR for this at #2090

[DanTup]

@scheglov thanks!

My main motivation here is to roll this into the SDK which I think just pulls this whole repo from a git hash, so there's no urgency to publish the release for this (if it's even required, from the comments above I wonder if it's automated).