Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unified_analytics should export DashEvent and DevicePlatform #234

Closed
goderbauer opened this issue Feb 16, 2024 · 1 comment
Closed

unified_analytics should export DashEvent and DevicePlatform #234

goderbauer opened this issue Feb 16, 2024 · 1 comment
Labels
package:unified_analytics

Comments

@goderbauer
Copy link
Contributor

See flutter/flutter#143594. Consumers currently have to use these via src imports, which the implementation_imports flags.

Justification for exporting them:

DashEvent is referenced in the public API of the package (example: https://pub.dev/documentation/unified_analytics/latest/unified_analytics/Event/eventName.html), therefore it should be exported and be publicly available as well.

DevicePlatform is expected to be used in tests.
@goderbauer
Copy link
Contributor Author

@eliasyishak FYI

@goderbauer goderbauer mentioned this issue Feb 16, 2024
Merged
This was referenced Feb 26, 2024
Merged
Merged
auto-submit bot pushed a commit to flutter/flutter that referenced this issue Feb 27, 2024
@eliasyishak
Clean up lint ignores (#144229)
d3b60d4 
Fixes:
- dart-lang/tools#234

Bumps the version for package:unified_analytics and removes TODOs and lint ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:unified_analytics
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

234-unified_analytics-should-export-dashevent-and-deviceplatform eliasyishak/tools
3 participants
@goderbauer @mosuem @eliasyishak