Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unified_analytics] Create class NoOpAnalytics implements Analytics #76

Closed
christopherfujino opened this issue Apr 7, 2023 · 0 comments · Fixed by #77
Closed

[unified_analytics] Create class NoOpAnalytics implements Analytics #76

christopherfujino opened this issue Apr 7, 2023 · 0 comments · Fixed by #77

Comments

@christopherfujino
Copy link
Member

To un-block rolling flutter/flutter#124015 internally, I had to write a class NoOpAnalytics implements Analytics from this package. However, this will cause problems the next time this interface changes when we try to roll package:unified_analytics internally. Thus, the class should be implemented in this package.

Also, the type ToolInfo should be exported from this package, since it is returned from a public method on Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant