Skip to content

Fixing structure issue of nested lists indented by tabs (#2172) #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

Fixing structure issue of nested lists indented by tabs (#2172) #2173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/markdown/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Update `package:web` API references in the example.
* Fix performance and correctness of HTML comment parser.
* Require Dart `^3.4.0`.
* Fix an issue with nested list structure when indented by tabs (#2172).

## 7.3.0

Expand Down
4 changes: 3 additions & 1 deletion pkgs/markdown/lib/src/block_syntaxes/list_syntax.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,9 @@ abstract class ListSyntax extends BlockSyntax {
// any indentation past the required whitespace character.
indent = precedingWhitespaces;
} else {
indent = precedingWhitespaces + contentWhitespances;
indent = precedingWhitespaces +
contentWhitespances +
(parser.current.tabRemaining ?? 0);
}

taskListItemState = null;
Expand Down
75 changes: 75 additions & 0 deletions pkgs/markdown/test/original/unordered_lists.unit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,26 @@ two</li>

* two

<<<
<ul>
<li>
<p>one</p>
<ul>
<li>nested one</li>
<li>nested two</li>
</ul>
</li>
<li>
<p>two</p>
</li>
</ul>
>>> can nest lists by tabs
* one
* nested one
* nested two

* two

<<<
<ul>
<li>
Expand Down Expand Up @@ -149,3 +169,58 @@ item</li>
<li>list</li>
</ul>
<hr />
>>> can nest multiple levels with tabs.
- Level 1, 1
- Level 1, 2
- Level 2, 1
- Level 2, 2
- Level 3, 1
- Level 3, 2
- Level 3, 3
- Level 4, 1
- Level 4, 2
- Level 4, 3
- Level 5, 1
- Level 5, 2
- Level 5, 3
- Level 5, 4
- Level 6, 1
- Level 6, 2
- Level 6, 3
- Level 1, 4
<<<
<ul>
<li>Level 1, 1</li>
<li>Level 1, 2
<ul>
<li>Level 2, 1</li>
<li>Level 2, 2
<ul>
<li>Level 3, 1</li>
<li>Level 3, 2</li>
<li>Level 3, 3
<ul>
<li>Level 4, 1</li>
<li>Level 4, 2</li>
<li>Level 4, 3
<ul>
<li>Level 5, 1</li>
<li>Level 5, 2</li>
<li>Level 5, 3</li>
<li>Level 5, 4
<ul>
<li>Level 6, 1</li>
<li>Level 6, 2</li>
<li>Level 6, 3</li>
</ul>
</li>
</ul>
</li>
</ul>
</li>
</ul>
</li>
</ul>
</li>
<li>Level 1, 4</li>
</ul>