-
Notifications
You must be signed in to change notification settings - Fork 77
Make link handling consistent across native watchers. #2261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
333b9ea to
b304e5a
Compare
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| watcher | Non-Breaking | 1.1.4 | 1.1.5-wip | 1.2.0 Got "1.1.5-wip" expected >= "1.2.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/watcher/lib/src/directory_watcher/directory_list.dart | 💔 67 % ⬇️ 1 % |
| pkgs/watcher/lib/src/directory_watcher/mac_os.dart | 💔 0 % ⬇️ NaN % |
| pkgs/watcher/lib/src/directory_watcher/windows.dart | 💔 0 % ⬇️ NaN % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
b304e5a to
5191aff
Compare
While rewriting the Linux watcher I realized that there was no practical way to implement the current behavior where it sometimes handles links as files and sometimes follows them.
Since the underlying native watchers report links as files, treat links as files always in these watchers.
The polling watcher had and still has different behavior, it follows links. (But now fixed for performance!)
Update tests and CHANGELOG to reflect all this :)
Tweak e2e test timeouts and run counts due to a timeout on Windows.