[unified_analytics 5.8.8] Prevent FileSystemExceptions from happening when logging outgoing events
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Analytics.send` (#274)
* delete old log file if it exceeds kMaxLogFileSize of 25MiB * update changelog * bump version in pubspec.yaml * update constants.dart
andrewkolos
changed the title
FileSystemExceptions from happening when logging outgoing payloadsFileSystemExceptions from happening when logging outgoing events
|
@devoncarew My intention here is to create a patch for unified_analytics v5 (5.8.8+2). Here's what I've done so far/plan to do:
Let me know if you think this won't work. |
|
It looks like CI only watches the main branch, so I'm not sure what the workflow would be here. |
|
This broadly makes sense. A few notes:
|
|
Oops, I probably should have ran the tests before merging 😛. I'll probably just fix the new branch directly. |
|
The tests should have run for this PR automatically. Looking at the config, it looks like its set up to only run for PRs which target |
This was referenced Jun 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 1, 2024
…8+1 to 5.8.8+2 (#151046) Resolves #150137 (the issue is already resolved in master with the use of package:unified_analytics:6.1.2). Patches the fixes from [unified_analytics:5.8.8+2](dart-lang/tools#280) to stable.
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should. This updates our GitHub CI configs to run checks against PRs against any branch. --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
andrewkolos
added a commit
that referenced
this pull request
Nov 21, 2024
This is a follow-up to #280 (comment). In summary, we only run CI checks on PRs against the main branch. However, in cases where an older major version of a package needs to be patched, it doesn't make sense to PR against main. CI won't run for these PRs, but it probably should. This updates our GitHub CI configs to run checks against PRs against any branch. --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this is to patch unified_analytics v5 with the fixes from #274 and #277.
In summary, unified_analytics logs (the 2500 most-recent) outgoing analytics events. This is primarily to be read in the future for targeted surveys. However, due to some unknown edge case(s) (investigation pending), it's possible this file can reach a massive size. #277 fixed this for unified_analytics v6, but we need to port this to v5, because the stable branch of Flutter (which we want to hotfix) uses v5.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.