Fix dictionary constructors to accept supertype members and create an…

… empty object when there are no fields (#197) Dictionaries can contain their supertypes' members as well and therefore, these constructors should accept them. https://webidl.spec.whatwg.org/#idl-dictionaries #188 We also emit some empty dictionary constructors, but because they are empty, they are treated as named constructors instead of object literal constructors. They should instead call JSObject() to create an empty object. Since some supertype fields are marked required, this is technically a breaking change as calling the same dictionary constructor requires those members now. Therefore, bump to 0.6.0-wip.
dart-lang · Mar 5, 2024 · 51e594b · 51e594b
1 parent 4af904f
commit 51e594b
Show file tree

Hide file tree

Showing 40 changed files with 835 additions and 90 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.6.0-wip
+
+- Added supertypes' fields to dictionary constructors as dictionaries are
+  allowed to contain those fields.
+- Empty dictionary constructors now create an empty object instead of being
+  treated like non-object literal `external` constructors.
+
 ## 0.5.1
 
 - Add [`TrustedTypes`](https://web.dev/trusted-types) members.

diff --git a/lib/src/dom/clipboard_apis.dart b/lib/src/dom/clipboard_apis.dart
@@ -22,7 +22,12 @@ typedef ClipboardItemData = JSPromise<JSAny>;
 typedef ClipboardItems = JSArray<ClipboardItem>;
 typedef PresentationStyle = String;
 extension type ClipboardEventInit._(JSObject _) implements EventInit, JSObject {
-  external factory ClipboardEventInit({DataTransfer? clipboardData});
+  external factory ClipboardEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
+    DataTransfer? clipboardData,
+  });
 
   external set clipboardData(DataTransfer? value);
   external DataTransfer? get clipboardData;
@@ -136,7 +141,10 @@ extension type ClipboardUnsanitizedFormats._(JSObject _) implements JSObject {
 }
 extension type ClipboardPermissionDescriptor._(JSObject _)
     implements PermissionDescriptor, JSObject {
-  external factory ClipboardPermissionDescriptor({bool allowWithoutGesture});
+  external factory ClipboardPermissionDescriptor({
+    required String name,
+    bool allowWithoutGesture,
+  });
 
   external set allowWithoutGesture(bool value);
   external bool get allowWithoutGesture;

diff --git a/lib/src/dom/credential_management.dart b/lib/src/dom/credential_management.dart
@@ -188,6 +188,7 @@ extension type PasswordCredential._(JSObject _)
 extension type PasswordCredentialData._(JSObject _)
     implements CredentialData, JSObject {
   external factory PasswordCredentialData({
+    required String id,
     String name,
     String iconURL,
     required String origin,
@@ -243,6 +244,7 @@ extension type FederatedCredentialRequestOptions._(JSObject _)
 extension type FederatedCredentialInit._(JSObject _)
     implements CredentialData, JSObject {
   external factory FederatedCredentialInit({
+    required String id,
     String name,
     String iconURL,
     required String origin,

diff --git a/lib/src/dom/csp.dart b/lib/src/dom/csp.dart
@@ -72,6 +72,9 @@ extension type SecurityPolicyViolationEvent._(JSObject _)
 extension type SecurityPolicyViolationEventInit._(JSObject _)
     implements EventInit, JSObject {
   external factory SecurityPolicyViolationEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
     required String documentURI,
     String referrer,
     String blockedURI,

diff --git a/lib/src/dom/css_animations.dart b/lib/src/dom/css_animations.dart
@@ -31,6 +31,9 @@ extension type AnimationEvent._(JSObject _) implements Event, JSObject {
 }
 extension type AnimationEventInit._(JSObject _) implements EventInit, JSObject {
   external factory AnimationEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
     String animationName,
     num elapsedTime,
     String pseudoElement,

diff --git a/lib/src/dom/css_font_loading.dart b/lib/src/dom/css_font_loading.dart
@@ -126,7 +126,12 @@ extension type FontFacePalettes._(JSObject _) implements JSObject {
 }
 extension type FontFaceSetLoadEventInit._(JSObject _)
     implements EventInit, JSObject {
-  external factory FontFaceSetLoadEventInit({JSArray<FontFace> fontfaces});
+  external factory FontFaceSetLoadEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
+    JSArray<FontFace> fontfaces,
+  });
 
   external set fontfaces(JSArray<FontFace> value);
   external JSArray<FontFace> get fontfaces;

diff --git a/lib/src/dom/css_transitions.dart b/lib/src/dom/css_transitions.dart
@@ -31,6 +31,9 @@ extension type TransitionEvent._(JSObject _) implements Event, JSObject {
 extension type TransitionEventInit._(JSObject _)
     implements EventInit, JSObject {
   external factory TransitionEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
     String propertyName,
     num elapsedTime,
     String pseudoElement,

diff --git a/lib/src/dom/cssom_view.dart b/lib/src/dom/cssom_view.dart
@@ -31,6 +31,7 @@ extension type ScrollOptions._(JSObject _) implements JSObject {
 extension type ScrollToOptions._(JSObject _)
     implements ScrollOptions, JSObject {
   external factory ScrollToOptions({
+    ScrollBehavior behavior,
     num left,
     num top,
   });
@@ -99,6 +100,9 @@ extension type MediaQueryListEvent._(JSObject _) implements Event, JSObject {
 extension type MediaQueryListEventInit._(JSObject _)
     implements EventInit, JSObject {
   external factory MediaQueryListEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
     String media,
     bool matches,
   });
@@ -135,6 +139,7 @@ extension type CaretPosition._(JSObject _) implements JSObject {
 extension type ScrollIntoViewOptions._(JSObject _)
     implements ScrollOptions, JSObject {
   external factory ScrollIntoViewOptions({
+    ScrollBehavior behavior,
     ScrollLogicalPosition block,
     ScrollLogicalPosition inline,
   });

diff --git a/lib/src/dom/dom.dart b/lib/src/dom/dom.dart
@@ -218,7 +218,12 @@ extension type CustomEvent._(JSObject _) implements Event, JSObject {
   external JSAny? get detail;
 }
 extension type CustomEventInit._(JSObject _) implements EventInit, JSObject {
-  external factory CustomEventInit({JSAny? detail});
+  external factory CustomEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
+    JSAny? detail,
+  });
 
   external set detail(JSAny? value);
   external JSAny? get detail;
@@ -363,6 +368,7 @@ extension type EventListenerOptions._(JSObject _) implements JSObject {
 extension type AddEventListenerOptions._(JSObject _)
     implements EventListenerOptions, JSObject {
   external factory AddEventListenerOptions({
+    bool capture,
     bool passive,
     bool once,
     AbortSignal signal,

diff --git a/lib/src/dom/encrypted_media.dart b/lib/src/dom/encrypted_media.dart
@@ -188,6 +188,9 @@ extension type MediaKeyMessageEvent._(JSObject _) implements Event, JSObject {
 extension type MediaKeyMessageEventInit._(JSObject _)
     implements EventInit, JSObject {
   external factory MediaKeyMessageEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
     required MediaKeyMessageType messageType,
     required JSArrayBuffer message,
   });
@@ -215,6 +218,9 @@ extension type MediaEncryptedEvent._(JSObject _) implements Event, JSObject {
 extension type MediaEncryptedEventInit._(JSObject _)
     implements EventInit, JSObject {
   external factory MediaEncryptedEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
     String initDataType,
     JSArrayBuffer? initData,
   });

diff --git a/lib/src/dom/fileapi.dart b/lib/src/dom/fileapi.dart
@@ -103,7 +103,11 @@ extension type File._(JSObject _) implements Blob, JSObject {
 }
 extension type FilePropertyBag._(JSObject _)
     implements BlobPropertyBag, JSObject {
-  external factory FilePropertyBag({int lastModified});
+  external factory FilePropertyBag({
+    String type,
+    EndingType endings,
+    int lastModified,
+  });
 
   external set lastModified(int value);
   external int get lastModified;

diff --git a/lib/src/dom/gamepad.dart b/lib/src/dom/gamepad.dart
@@ -99,7 +99,12 @@ extension type GamepadEvent._(JSObject _) implements Event, JSObject {
   external Gamepad get gamepad;
 }
 extension type GamepadEventInit._(JSObject _) implements EventInit, JSObject {
-  external factory GamepadEventInit({required Gamepad gamepad});
+  external factory GamepadEventInit({
+    bool bubbles,
+    bool cancelable,
+    bool composed,
+    required Gamepad gamepad,
+  });
 
   external set gamepad(Gamepad value);
   external Gamepad get gamepad;

diff --git a/lib/src/dom/geometry.dart b/lib/src/dom/geometry.dart
@@ -458,6 +458,18 @@ extension type DOMMatrix2DInit._(JSObject _) implements JSObject {
 extension type DOMMatrixInit._(JSObject _)
     implements DOMMatrix2DInit, JSObject {
   external factory DOMMatrixInit({
+    num a,
+    num b,
+    num c,
+    num d,
+    num e,
+    num f,
+    num m11,
+    num m12,
+    num m21,
+    num m22,
+    num m41,
+    num m42,
     num m13,
     num m14,
     num m23,