-
Notifications
You must be signed in to change notification settings - Fork 32
[web_generator] Setting up web_generator
for Dart JS Interop Gen
#368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web_generator] Setting up web_generator
for Dart JS Interop Gen
#368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool to see us adding TSC and potentially start using it!
web_generator
to add support for Dart JS Interop Interface Generation
web_generator
to add support for Dart JS Interop Interface Generationweb_generator
for Dart JS Interop Gen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The tests don't run by default because they are VM tests. |
Also diff --git a/web_generator/test/ts_bindings_test.dart b/web_generator/test/ts_bindings_test.dart
index 3470d7a..8ef208a 100644
--- a/web_generator/test/ts_bindings_test.dart
+++ b/web_generator/test/ts_bindings_test.dart
@@ -9,13 +9,12 @@ import 'package:test/test.dart';
import 'package:web_generator/src/cli.dart';
void main() {
- final testGenFolder = p.join('test', 'gen');
- final testGenDTSFiles = p.join(testGenFolder, 'input');
-
group('Web Generator TS Bindings Integration Test', () {
+ final testGenFolder = p.join('test', 'gen');
+ final testGenDTSFiles = p.join(testGenFolder, 'input');
final inputDir = Directory(testGenDTSFiles);
- setUp(() async {
+ setUpAll(() async {
// set up npm
await runProc('npm', ['install'],
workingDirectory: bindingsGeneratorPath, detached: true); Should keep the group vars together. |
It looks like we were skipping a test already because of this: #373. @nikeokoronkwo I filed #372 to track unskipping this test now that I'm enabling it in the CI. We should add a |
I wanted to work on test implementation once we started working on declarations, as adding test cases now would fail anyways.
The folder I used for this is |
This PR is for setting up the
web_generator
to begin adding support for generating Dart JS interop interface code from TypeScript Declaration Code.For more information, see the project overview