Skip to content

Commit

Permalink
deprecated sound/weak sdkSummaryPath for SdkLayout class but kept var…
Browse files Browse the repository at this point in the history
…iables in constructor to avoid breaking changes
  • Loading branch information
jyameo committed Oct 10, 2024
1 parent 5718438 commit 64ba845
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

- Replace deprecated JS code `this.__proto__` with `Object.getPrototypeOf(this)`. - [#2500](https://github.com/dart-lang/webdev/pull/2500)
- Migrate injected client code to `package:web`. - [#2491](https://github.com/dart-lang/webdev/pull/2491)
- Deprecated MetadataProvider's, CompilerOptions' & SdkConfiguration's soundNullSafety. - [#2427](https://github.com/dart-lang/webdev/issues/2427)
- Deprecated MetadataProvider's, CompilerOptions', SdkConfiguration's & SdkLayout's soundNullSafety. - [#2427](https://github.com/dart-lang/webdev/issues/2427)

## 24.1.0

Expand Down
8 changes: 8 additions & 0 deletions dwds/lib/src/utilities/sdk_configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ class SdkLayout {
final String summaryPath;
final String dartdevcSnapshotPath;

@Deprecated('Only sound null safety is supported as of Dart 3.0')
final String soundSummaryPath;

@Deprecated('Only sound null safety is supported as of Dart 3.0')
final String weakSummaryPath;

SdkLayout.createDefault(String sdkDirectory)
: this(
sdkDirectory: sdkDirectory,
Expand All @@ -65,6 +71,8 @@ class SdkLayout {
const SdkLayout({
required this.sdkDirectory,
required this.summaryPath,
this.soundSummaryPath = '',
this.weakSummaryPath = '',
required this.dartdevcSnapshotPath,
});
}
Expand Down

0 comments on commit 64ba845

Please sign in to comment.