Skip to content

Match VM behavior when setting and removing breakpoints #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Apr 22, 2021

Match VM behavior:

  • allow to set exiting breakpoint
  • throw RPCError if removing existing breakpoint

Closes:flutter/flutter#74903
Closes:flutter/flutter-intellij#5128

@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@annagrin annagrin requested a review from grouma April 22, 2021 04:50
@annagrin annagrin changed the title Allow adding existing breakpoints and removing non-existing ones Match VM behavior when setting and removing breakpoints Apr 22, 2021
Anna Gringauze added 3 commits April 27, 2021 16:28
Match VM behavior where a breakpoint is allowed to be set
and removed even if it exists.

Closes:flutter/flutter#74903
@annagrin annagrin force-pushed the annagrin/allow_setting_existing_breakpoints branch from 01614af to f5d6528 Compare April 27, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants