Run instance tests with frontend server #2160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
annagrin
commented
Jun 26, 2023
elliette
reviewed
Jun 26, 2023
elliette
approved these changes
Jun 26, 2023
Contributor
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
One suggestion but LGTM!
elliette
reviewed
Jun 28, 2023
elliette
reviewed
Jun 28, 2023
…n-instance-test-frontend-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running instance_test.dart only with build daemon compilation.
Running instance tests with frontend server required specifying the
basePathvia the asset reader. (Previous automaticbasePathdiscovery was not correct for the instance tests).In this PR:
basePathindev_handler.dart.Closes: #2158