Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pub/dart invoked by tests are the same as the top-level SDK #24

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Mar 28, 2018

Closes #23

@kevmoo kevmoo requested review from nshahan and natebosch March 28, 2018 21:30
@kevmoo
Copy link
Member Author

kevmoo commented Mar 28, 2018

I could imagine a LOT of head scratching trying to debug something w/ a mismatch here...

@kevmoo
Copy link
Member Author

kevmoo commented Mar 28, 2018

...something like this ought to be a package

Would it make sense to have this functionality in pkg:io or something?

@natebosch
Copy link
Member

Would it make sense to have this functionality in pkg:io or something?

It's already in cli_util. This logic also doesn't work internally.

@kevmoo
Copy link
Member Author

kevmoo commented Mar 28, 2018

This logic also doesn't work internally.

Well, it's less broken in more places w/ this at least...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants