Skip to content

Remove remaining MV2 logic #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Remove remaining MV2 logic #2453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dwds/debug_extension/tool/build_extension.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import 'package:args/args.dart';
import 'package:path/path.dart' as p;

const _prodFlag = 'prod';
const _mv2Flag = 'mv2';

void main(List<String> arguments) async {
final parser = ArgParser()
Expand All @@ -27,14 +26,13 @@ void main(List<String> arguments) async {

exitCode = await run(
isProd: argResults[_prodFlag] as bool,
isMV2: argResults[_mv2Flag] as bool,
);
if (exitCode != 0) {
_logWarning('Run terminated unexpectedly with exit code: $exitCode');
}
}

Future<int> run({required bool isProd, required bool isMV2}) async {
Future<int> run({required bool isProd}) async {
_logInfo(
'Building extension for ${isProd ? 'prod' : 'dev'}',
);
Expand Down