Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appveyor (Windows) CI #25

Merged
merged 2 commits into from
Apr 3, 2018
+32 −4
Merged

Add appveyor (Windows) CI #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc64335
Add appveyor (Windows) CI
kevmoo Apr 3, 2018
bb44773
Fixes to run on Windows
kevmoo Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
branches:
only:
- master

version: '1.0.{build}'

install:
- ps: wget https://storage.googleapis.com/dart-archive/channels/dev/release/latest/sdk/dartsdk-windows-x64-release.zip -OutFile dart-sdk.zip
- cmd: echo "Unzipping dart-sdk..."
- cmd: 7z x dart-sdk.zip -o"C:\tools" -y > nul
- set PATH=%PATH%;C:\tools\dart-sdk\bin
- set PATH=%PATH%;%APPDATA%\Pub\Cache\bin
- cd webdev
- pub get && exit 0

build: off

test_script:
- pub run test -j 1

cache:
- C:\Users\appveyor\AppData\Roaming\Pub\Cache
4 changes: 4 additions & 0 deletions webdev/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.3

- Now runs on Windows.

## 0.1.2

- Remove check for `build_web_compilers`. Allows general support for
Expand Down
2 changes: 1 addition & 1 deletion webdev/lib/src/pubspec.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class PackageExceptionDetails {
}

Future _runPubDeps() async {
var result = Process.runSync('pub', ['deps']);
var result = Process.runSync('pub', ['deps'], runInShell: true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I did this originally in build_runner but ended up getting other issues if I recall.... I can't remember exactly what they were though? We just add .bat conditionally now https://github.com/dart-lang/build/blob/57321fffbf27f8ff8c5837dd87ff95c695dbf4c2/build_runner/lib/src/entrypoint/options.dart#L31.

If this is working then its probably fine but just fyi.


if (result.exitCode == 65 || result.exitCode == 66) {
throw new PackageException._(
Expand Down
2 changes: 1 addition & 1 deletion webdev/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: webdev
version: 0.1.3-dev
version: 0.1.3
author: Dart Team <misc@dartlang.org>
homepage: https://github.com/dart-lang/webdev
description: >-
Expand Down
6 changes: 4 additions & 2 deletions webdev/test/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import 'package:test/test.dart';
import 'package:test_descriptor/test_descriptor.dart' as d;
import 'package:test_process/test_process.dart';

final _webdevBin = p.absolute('bin/webdev.dart');
final _webdevBin = p.absolute(p.join('bin', 'webdev.dart'));

/// The path to the root directory of the SDK.
final String _sdkDir = (() {
Expand Down Expand Up @@ -219,7 +219,9 @@ dependencies:
test('should succeed with valid configuration', () async {
var exampleDirectory = p.absolute(p.join(p.current, '..', 'example'));
var process = await TestProcess.start(_pubPath, ['get'],
workingDirectory: exampleDirectory, environment: _getPubEnvironment());
workingDirectory: exampleDirectory,
environment: _getPubEnvironment(),
runInShell: true);

await process.shouldExit(0);

Expand Down