Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use var/final consistently across repository #2502

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

parlough
Copy link
Member

@parlough parlough commented Oct 2, 2024

Before this change, only dwds was set up to prefer final, while the other projects used an inconsistent mix of var and final. This PR pulls the declaration of prefer_final_locals out to the shared analysis_options.yaml, adds prefer_final_in_for_each as well, and applies the fixes across the repository.

This will help reduce the question of which keyword to use when working in this repository.

Copy link
Collaborator

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

Copy link

auto-submit bot commented Oct 3, 2024

auto label is removed for dart-lang/webdev/2502, due to This PR has not met approval requirements for merging. The PR author is not a member of dart-team and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Copy link

auto-submit bot commented Oct 3, 2024

auto label is removed for dart-lang/webdev/2502, due to - The status or check suite Maybe prevent submission has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi merged commit e93891f into dart-lang:main Oct 3, 2024
61 of 62 checks passed
@parlough parlough deleted the misc/use-final-consistently branch October 3, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants