Use var/final consistently across repository #2502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, only
dwds
was set up to preferfinal
, while the other projects used an inconsistent mix ofvar
andfinal
. This PR pulls the declaration ofprefer_final_locals
out to the sharedanalysis_options.yaml
, addsprefer_final_in_for_each
as well, and applies the fixes across the repository.This will help reduce the question of which keyword to use when working in this repository.