Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for some debugging APIs with the DDC library bundle format - part 5 #2549

Merged
merged 16 commits into from
Jan 8, 2025
Merged

Added support for some debugging APIs with the DDC library bundle format - part 5 #2549

merged 16 commits into from
Jan 8, 2025

Conversation

jyameo
Copy link
Contributor

@jyameo jyameo commented Dec 18, 2024

Added support for some debugging APIs with the DDC library bundle format.

  • getRecordTypeFieldsJsExpression
  • callInstanceMethodJsExpression

fixes #2548

jyameo added 12 commits December 5, 2024 12:13
@jyameo
Added support for getClassMetadata with the DDc library bundle format
7caa652
@jyameo
Merge branch 'main' into yj-dartdevembedder-3
5f29674
@jyameo
Merge branch 'main' into yj-dartdevembedder-3
17a9775
@jyameo
Added support for some debugging APIs with the DDC library bundle for…
f3b2bd7 
…mat.
@jyameo
Update pattern test to account for new DDC JS variable naming
a1f017c
@jyameo
reverting change to pattern test
58b8762
@jyameo
Added support for debugging API with the DDC library bundle format.
c781e5f
@jyameo
Merge branch 'main' into yj-dartdevembedder-4
8a9006a
@jyameo
updated licenses
0b235e6
@jyameo
updated licenses and remove new line from changelog
607c7e4
@jyameo
Merge branch 'main' into yj-dartdevembedder-5
067ab27
@jyameo
Added support for some debugging APIs with the DDC library bundle for…
b9a8c2f 
…mat - getRecordTypeFieldsJsExpression, callInstanceMethodJsExpression
@jyameo jyameo requested a review from srujzs December 18, 2024 22:08
srujzs
srujzs approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it makes sense to keep that prototype check even with the new module format.

@jyameo jyameo merged commit 659e1df into dart-lang:main Jan 8, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement record_type_inspection_ddc_library_bundle_test
2 participants
@jyameo @srujzs