Support running pub when it's not on the environment path #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Apr 3, 2018
| import 'package:pub_semver/pub_semver.dart'; | ||
|
|
||
| final supportedBuildRunnerVersionRange = new VersionRange( | ||
| min: new Version(0, 8, 0), | ||
| includeMin: true, | ||
| max: new Version(0, 9, 0), | ||
| includeMax: false); | ||
|
|
||
| /// The path to the root directory of the SDK. | ||
| final String _sdkDir = (() { |
There was a problem hiding this comment.
should we be doing this instead of using cli_util?
There was a problem hiding this comment.
Not worth the dependency for a one-line method.
jakemac53
approved these changes
Apr 3, 2018
|
You need to replace |
|
Works fine for me now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.