[ DWDS ] Refactor AppInspector to support both Chrome and Web Socket connections
#2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connections Created two new subclasses of `AppInspector`: `ChromeAppInspector` and `WebSocketAppInspector`. Functionality that doesn't require knowledge of the specific DWDS connection mode (e.g., WIP vs WS) remains in the now abstract `AppInspector`, and functionality specific to the connection mode is now implemented in the respective `*AppInspector` subclass. This allows for sharing logic around maintaining caches for scripts and libraries.
bkonyi
changed the title
AppInspector to support both Chrome and Web Socket connections
bkonyi
force-pushed
the
refactor_app_inspector
branch
from
6109260 to
0fd4a05
Compare
bkonyi
requested review from
jyameo and
srujzs
and removed request for
jyameo
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
srujzs
approved these changes
Oct 20, 2025
|
autosubmit label was removed for dart-lang/webdev/2700, because - The status or check suite Maybe prevent submission has failed. Please fix the issues identified (or deflake) before re-applying this label. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 21, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. tools (https://github.com/dart-lang/tools/compare/d0941a3..ce12670): ce126700 Mon Oct 20 21:50:45 2025 +0100 Danny Tuppeny Fix @failingTest not working correctly for out-of-band exceptions (dart-lang/tools#2216) 8bb94d88 Mon Oct 20 16:14:33 2025 +0200 Sebastian Stallenberger [oauth2] Add isClosed and exception handling for closed state to oaut… (dart-lang/tools#2089) webdev (https://github.com/dart-lang/webdev/compare/82b3855..b9c39c0): b9c39c00 Mon Oct 20 15:52:13 2025 -0400 Ben Konyi [ DWDS ] Refactor `AppInspector` to support both Chrome and Web Socket connections (dart-lang/webdev#2700) Change-Id: I1e989df7dbfcbc99afe7dfcd0920a8fb0be5e4db Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/456260 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Danny Tuppeny <danny@tuppeny.com> Reviewed-by: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created two new subclasses of
AppInspector:ChromeAppInspectorandWebSocketAppInspector. Functionality that doesn't require knowledge of the specific DWDS connection mode (e.g., WIP vs WS) remains in the now abstractAppInspector, and functionality specific to the connection mode is now implemented in the respective*AppInspectorsubclass.This allows for sharing logic around maintaining caches for scripts and libraries.