Adding better guards for DDC loader injection logic #2733
+454
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issues introduced in e2d14f1
Flutter's DDC impl depends on DWDS injecting the logic that begins script loading. This logic isn't used by the Frontend Server implementation in package:build, which is toggled by the
canaryflag in webdev. This change adds a guard that ensures Flutter impls continue to get this injected loader regardless of the downstream work.This also adds a separate build_runner + Frontend Server test target (no tests currently use this). Filters propagated to tests as well.