Remove built_value dependency from ServiceExtensionRequest & ServiceExtensionResponse #2735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceExtensionRequest:
This PR removes the
package:built_valuedependency fromServiceExtensionRequestand replaces it with standard Dart JSON serialization.Changes
ServiceExtensionRequestas a simple Dart class with manual JSON serializationServiceExtensionRequestfrom the@SerializersForannotation in serializers.dartServiceExtensionRequestusing the wire format['ServiceExtensionRequest', request.toJson()]in_serializeMessage()ServiceExtensionRequestcase to_deserializeEvent()helper in client.dart to deserialize from wire formatfromArgs()factory methodTesting
HotReloadRequest,HotReloadResponse,HotRestartRequest, andHotRestartResponseFixes dart-lang/sdk#62302
ServiceExtensionResponse:
This PR removes the
package:built_valuedependency fromServiceExtensionResponseand replaces it with standard Dart JSON serialization.Changes
ServiceExtensionResponseas a simple Dart class with manual JSON serializationServiceExtensionResponsefrom the@SerializersForannotation in serializers.dartServiceExtensionResponseusing the wire format['ServiceExtensionResponse', response.toJson()]in_sendServiceExtensionResponse()ServiceExtensionResponsecase to_deserializeMessage()helper in dev_handler.dart to deserialize from wire formatfromResult()factory method for convenience and simplified theresultfield to beMap<String, dynamic>?instead of encoded JSON stringTesting
HotReloadRequest,HotReloadResponse,HotRestartRequest, andHotRestartResponseFixes dart-lang/sdk#62303