Update readme to document build and serve feature #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
changed the title
natebosch
reviewed
Apr 9, 2018
webdev/test/readme_test.dart
Outdated
| @@ -0,0 +1,34 @@ | |||
| // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | |||
webdev/test/test_utils.dart
Outdated
| @@ -0,0 +1,18 @@ | |||
| // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file | |||
| Usage: webdev build [arguments] | ||
| -h, --help Print this usage information. | ||
| -r, --[no-]release Build with release mode defaults for builders. | ||
| (defaults to on) |
There was a problem hiding this comment.
What do you mean by "on"?
And where are you setting this default? Was that in another PR?
There was a problem hiding this comment.
Ah yeah, found the other PR...
|
@natebosch – fixed dates – although I zero epsilon chance it'd cause any issues... |
natebosch
approved these changes
Apr 9, 2018
webdev/test/readme_test.dart
Outdated
|
|
||
| try { | ||
| expect(readme.readAsStringSync(), contains(expected)); | ||
| } catch (e) { |
There was a problem hiding this comment.
How about
printOnFailure(expected);
expect(readme.readAsStringSync(), contains(expected));
|
Nooice!
…On Mon, Apr 9, 2018 at 12:20 PM Nate Bosch ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In webdev/test/readme_test.dart
<#30 (comment)>:
> + test('help serve', () => _readmeCheck(['help', 'serve']));
+}
+
+Future _readmeCheck(List<String> args) async {
+ var process = await runWebDev(args);
+ var output = (await process.stdoutStream().join('\n')).trim();
+ await process.shouldExit(0);
+
+ var readme = new File('README.md');
+
+ var command = (['webdev']..addAll(args)).join(' ');
+ var expected = '```console\n\$ $command\n$output\n```';
+
+ try {
+ expect(readme.readAsStringSync(), contains(expected));
+ } catch (e) {
How about
printOnFailure(expected);expect(readme.readAsStringSync(), contains(expected));
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCiv5pBLRHjysRiokHSucMB-oyHzz4ks5tm7SQgaJpZM4TM_3U>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.