Pass the remaining args when running serve #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you think of a sane way to test that we don't regress on this feature? |
An integration test... |
kevmoo
requested changes
Apr 10, 2018
| @@ -49,6 +49,9 @@ class ServeCommand extends CommandBase { | |||
| arguments.add('--log-requests'); | |||
| } | |||
|
|
|||
| // The remaining arguments should be interpreted as [<directory>[:<port>]]. | |||
| arguments.addAll(argResults.rest); | |||
There was a problem hiding this comment.
Please bump the version and add a -dev, and add a note in the changelog
There was a problem hiding this comment.
@nshahan – I took care of the rebase and changelog. Taking a look at an integration test now...
kevmoo
approved these changes
Apr 11, 2018
jakemac53
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you so specify a directory:port when running the serve command.