Set --fail-on-severe always for webdev build.
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
requested changes
Apr 25, 2018
Member
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
Please add an entry to the changelog, too!
|
|
||
| Future<int> runCore(String command) async { | ||
| Future<int> runCore(String command, | ||
| {List<String> extraArgs = const []}) async { |
Member
There was a problem hiding this comment.
I'd leave the default value unset here...
| var buildRunnerScript = await _buildRunnerScript(); | ||
|
|
||
| final arguments = [command]..addAll(getArgs()); | ||
| final arguments = [command]..addAll(extraArgs)..addAll(getArgs()); |
Member
There was a problem hiding this comment.
and use extraArgs ?? const [] here.
Super paranoid handling of someone passing runCore('foo', extraArgs: null)
alorenzen
force-pushed
the
fail-on-severe
branch
from
4571a3a to
d2ec16a
Compare
Contributor
Author
|
PTAL. |
kevmoo
approved these changes
Apr 27, 2018
Member
|
@alorenzen – going to merge on red. Will fix the unrelated test failure in a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44