Faster DevTools launch #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-knight
approved these changes
Oct 17, 2019
| @@ -14,17 +15,19 @@ import '../../data/serializers.dart'; | |||
| class AppConnection { | |||
| /// The initial connection request sent from the application in the browser. | |||
| final ConnectRequest request; | |||
|
|
|||
| final _startCompleter = Completer(); | |||
| final SseConnection _connection; | |||
There was a problem hiding this comment.
nit: startCompleter sounds like an action, which is a bit confusing. Maybe _startupCompleter, or _startedCompleter? Or even just '_startup', as it's private in a pretty narrow scope, and Dart style avoids reiterating types in variable names. if (_startup.isCompleted) reads pretty well. And a comment wouldn't hurt.
| @@ -42,15 +43,20 @@ class ChromeProxyService implements VmServiceInterface { | |||
| /// are dynamic and roughly map to chrome tabs. | |||
| final VM _vm; | |||
|
|
|||
| // TODO(flutter/devtools/issues/1207) - Remove. | |||
| final _vmReadyCompleter = Completer(); | |||
There was a problem hiding this comment.
Completer of bool? void?
jakemac53
approved these changes
Oct 17, 2019
| uri, | ||
| instanceHelper, | ||
| ); | ||
|
|
||
| unawaited(appConnection.onStart.then((_) async { | ||
| unawaited((await _debugger).resumeFromStart()); |
There was a problem hiding this comment.
[nit]: this can actually await
This was referenced Apr 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CreateIsolateto complete or the debugger to be enabled before creating theChromeProxyServicecorrectTabevals as they are no longer necessaryRunResponseas the run state is now properly stored in theAppConnection