Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 2.1.1 release #52

Merged
merged 1 commit into from
May 2, 2023
Merged

Prepare 2.1.1 release #52

merged 1 commit into from
May 2, 2023

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented May 2, 2023

No description provided.

@jonasfj jonasfj requested review from sigurdm and szakarias and removed request for sigurdm May 2, 2023 11:31
szakarias
szakarias approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sigurdm
sigurdm approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind approving, but I don't see the benefit of publishing a package with a restricted sdk constraint as only change.

@jonasfj
Copy link
Member Author

jonasfj commented May 2, 2023

We also added topics :D

@jonasfj jonasfj merged commit e05282b into dart-lang:main May 2, 2023
@jonasfj jonasfj deleted the prepare-release branch May 2, 2023 12:02
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
@jonasfj
Prepare 2.1.1 release (dart-lang/yaml_edit#52)
3ea66cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@szakarias szakarias szakarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasfj @szakarias @sigurdm