-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make lnlambda.lnmetrics.info default lamdaServer url #143
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for clnapp failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7147ea5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the solution that I had in mind, but it is just a default value.
The URL should be a choice of the user from a list of options
@@ -41,7 +41,7 @@ class _LnlambdaSettingViewState extends State<LnlambdaSettingView> { | |||
), | |||
const Text("Lambda Server"), | |||
TextFormField( | |||
controller: TextEditingController(text: setting.lambdaServer ?? ''), | |||
controller: TextEditingController(text: setting.lambdaServer), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
controller: TextEditingController(text: setting.lambdaServer), | |
controller: TextEditingController(text: setting.lambdaServer), |
we can use another component? maybe a PopupMenuButton https://api.flutter.dev/flutter/material/PopupMenuButton-class.html or something similar?
Yes that can be done. We can have a dropdown from which the user can select one of the many lambda URLs. Among the options in the dropdown, one option can be |
Sounds good |
Here's a demo video of how this will work CLN.App.-.20.February.2024.mp4 |
@mdmohsin7 instead to set the first value to an empty one, can you set it to the lnmetrics URL? Thanks |
This is done. CLN.App.-.13.March.2024.mp4 |
176d4dd
to
93e980e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks good.
Can you address the last review that I left?
then if you can rebase on top of master will be a good step, thanks
Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
looks like that it needs a rebase |
While setting up connection type of
ClientMode.lnlambda
, the user has to provide a URL for a lambda server. Those who aren't aware of any, they can uselnlambda.lnmetrics.info
, but this thing isn't documented anywhere. Hence this PR makeshttps://lnlambda.lnmetrics.info
the default option for lambda server which the user can change if they want to.