Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making friction and restitution properties belong to CollisionAspect instead of BodyNode #1179

Closed
mxgrey opened this issue Oct 23, 2018 · 1 comment
Assignees
Labels
priority: medium should be resolved before the next release tag: feature request Indicates new feature requests
Milestone

Comments

@mxgrey
Copy link
Member

mxgrey commented Oct 23, 2018

Currently coefficient of friction and coefficient of restitution are defined per BodyNode. I would propose defining them per geometric object by putting them into CollisionAspect::Properties instead of BodyNode::Properties. I think this may have been discussed before, but I can't find where that conversation may have happened.

This is somewhat related to #716.

@mxgrey mxgrey added priority: medium should be resolved before the next release tag: feature request Indicates new feature requests comp: dynamics labels Oct 23, 2018
@mxgrey mxgrey self-assigned this Oct 23, 2018
@mxgrey mxgrey added this to the DART 7.0.0 milestone Oct 23, 2018
@jslee02
Copy link
Member

jslee02 commented Jul 14, 2019

Now they are in DynamicsAspect, and the APIs in BodyNode are deprecated in #1369.

@jslee02 jslee02 closed this as completed Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium should be resolved before the next release tag: feature request Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants