-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix friction and restitution of individual shapes in a body #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
changed the title
Fix setting friction and restitution of individual shapes in a body
Fix friction and restitution of individual shapes in a body
Jul 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
=========================================
Coverage ? 56.97%
=========================================
Files ? 366
Lines ? 27460
Branches ? 0
=========================================
Hits ? 15646
Misses ? 11814
Partials ? 0
|
this looks good to me. I'll try rebasing my branch onto this tomorrow morning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicAspect
was introduced to allow to set different dynamics properties (including friction and restitution properties) per shape in aBodyNode
for setting the dynamic properties of individual shapes in aBodyNode
. However, the constraint solver still uses the dynamics properties stored inBodyNode
.This PR deprecates the friction and restitution property related APIs in
BodyNode
and change the constraint solver to use the dynamics properties inDynamicAspect
.Resolves #200.
Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md