Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Use .hpp for headers when switching to the new package name #568

Closed
mxgrey opened this issue Dec 8, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@mxgrey
Copy link
Member

mxgrey commented Dec 8, 2015

In various discussions, I've heard interest in the idea of having C-bindings for DART since this would enable easier interfacing with other programming languages, and therefore easier integration into other frameworks. If someone were to implement C-bindings, the most natural file organization would be to have C API headers use .h while C++ API headers use .hpp, but in our current file organization all the C++ headers are already using .h.

Whether or not anyone is currently planning to implement C-bindings, I think it would be good to use the .hpp convention to allow for a clear delineation between the existing C++ API and a C API in case one is ever created. Since the package will be undergoing a highly interruptive name change in the near future anyway, I think that would be the best possible time to make a change like this.

@jslee02
Copy link
Member

jslee02 commented Dec 8, 2015

👍 It sounds reasonable.

@jslee02 jslee02 added this to the [NEW_NAME] 1.0.0 milestone Dec 8, 2015
jslee02 added a commit that referenced this issue Jan 13, 2016
Here are exceptions:
./kido/lcpsolver/matrix.h
./kido/lcpsolver/misc.h
./kido/lcpsolver/lcp.h
./kido/lcpsolver/error.h
./kido/lcpsolver/common.h
./kido/lcpsolver/odeconfig.h
./unittests/gtest/include/gtest/gtest_pred_impl.h
./unittests/gtest/include/gtest/gtest-spi.h
./unittests/gtest/include/gtest/gtest-message.h
./unittests/gtest/include/gtest/internal/gtest-filepath.h
./unittests/gtest/include/gtest/internal/gtest-string.h
./unittests/gtest/include/gtest/internal/gtest-tuple.h
./unittests/gtest/include/gtest/internal/gtest-linked_ptr.h
./unittests/gtest/include/gtest/internal/gtest-type-util.h
./unittests/gtest/include/gtest/internal/gtest-param-util.h
./unittests/gtest/include/gtest/internal/gtest-internal.h
./unittests/gtest/include/gtest/internal/gtest-port.h
./unittests/gtest/include/gtest/internal/gtest-death-test-internal.h
./unittests/gtest/include/gtest/internal/gtest-param-util-generated.h
./unittests/gtest/include/gtest/gtest_prod.h
./unittests/gtest/include/gtest/gtest-printers.h
./unittests/gtest/include/gtest/gtest-death-test.h
./unittests/gtest/include/gtest/gtest.h
./unittests/gtest/include/gtest/gtest-param-test.h
./unittests/gtest/include/gtest/gtest-test-part.h
./unittests/gtest/include/gtest/gtest-typed-test.h
./unittests/gtest/src/gtest-internal-inl.h
@jslee02 jslee02 modified the milestones: KIDO 0.1.0, KIDO 7.0.0 Jan 14, 2016
@jslee02 jslee02 modified the milestones: DART 6.0.0, KIDO 7.0.0 Mar 29, 2016
@jslee02 jslee02 self-assigned this Apr 22, 2016
@jslee02
Copy link
Member

jslee02 commented Apr 26, 2016

Addressed by #693

@jslee02 jslee02 closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants