Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #660 for DART 5.1 #776

Closed
jslee02 opened this issue Oct 4, 2016 · 1 comment
Closed

Backport #660 for DART 5.1 #776

jslee02 opened this issue Oct 4, 2016 · 1 comment
Milestone
DART 5.1.3

Comments

@jslee02
Copy link
Member

jslee02 commented Oct 4, 2016

requested
@jslee02 jslee02 added this to the DART 5.1.3 milestone Oct 4, 2016
scpeters pushed a commit that referenced this issue Oct 4, 2016
@scpeters
Support for Bullet built with double precision.
c6d5b2d 
Bullet requires a pre-processor variable to be set before including any
headers to determine whether the library was built with single or double
precision. Failing to do so may result in a linking error.

This commit:

1. Forces CMake to use CONFIG mode (BulletConfig.cmake shipped with
   bullet) instead of MODULE mode (FindBullet.cmake shipped with CMake
   by default) in find_package(Bullet).

2. Updates references to BULLET_INCLUDE_DIRS and BULLET_LIBRARIES
   accordingly

3. Test whether Bullet was built using double precision floating point
   numbers by attempting to compile code that produces a linking error
   when the necessary preprocessor definition is missing.

4. Set the necessary preprocessor definition in config.h.

combined with commits that
Reverted to using Bullet MODULE mode.
and
Minor output message update for consistency

Backport of #660 to release-5.1 branch.
Closes #776.
@scpeters scpeters mentioned this issue Oct 4, 2016
Merged
@jslee02
Copy link
Member Author

jslee02 commented Oct 5, 2016

Resolved by #777.

@jslee02 jslee02 closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 5.1.3
Development

No branches or pull requests
1 participant
@jslee02