Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use global namespace resolution in macro #1010

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Use global namespace resolution in macro #1010

merged 2 commits into from
Feb 24, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 24, 2018 •
edited
Loading

to avoid namespace conflicts

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md

@jslee02 jslee02 requested a review from mxgrey February 24, 2018 00:53
mxgrey
mxgrey approved these changes Feb 24, 2018
View reviewed changes
Copy link
Member

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jslee02 jslee02 added this to the DART 6.4.0 milestone Feb 24, 2018
@jslee02 jslee02 mentioned this pull request Feb 24, 2018
Closed
@jslee02 jslee02 merged commit b3156ef into release-6.4 Feb 24, 2018
@jslee02 jslee02 deleted the enhancement/console_macros branch February 25, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jslee02 @mxgrey