Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-source build script for examples/tutorials #1015

Merged
merged 7 commits into from
Feb 26, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Feb 26, 2018

This PR is prerequisite work for having examples and tutorials with various build settings like requiring additional dependencies. Up to now, in-source building for examples and tutorials was handled by macros (i.e., dart_add_example and dart_add_tutorial), but it wouldn't be straightforward to handle various build settings.

This PR adds separate build scripts for in-source builds (based on this suggestion). We are still able to build examples/tutorials out of source with installed DART.

Caveat

  • I found that osgWamIkFast doesn't work (at least on Ubuntu), and this will be addressed in another PR.
  • Out-of-source builds are not tested.

Before merging a pull request

@codecov
Copy link

codecov bot commented Feb 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (release-6.4@93215cf). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-6.4    #1015   +/-   ##
==============================================
  Coverage               ?   56.58%           
==============================================
  Files                  ?      314           
  Lines                  ?    24312           
  Branches               ?        0           
==============================================
  Hits                   ?    13758           
  Misses                 ?    10554           
  Partials               ?        0

@jslee02 jslee02 merged commit b637b9f into release-6.4 Feb 26, 2018
@jslee02 jslee02 deleted the examples/multiple_cmakelists branch February 26, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant