Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to DartResourceRetriever to search from environment variable DART_DATA_PATH #1095

Merged
merged 2 commits into from
Aug 6, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 5, 2018

This PR adds a fallback option to DartResourceRetriever to use an environment variable to search DART data files. The existing preprocessor, DART_DATA_GLOBAL_PATH, doesn't work if the package manager uses temporary install directory (e.g., Launchpad PPA and Homebrew).

This should resolve #1091 and dartsim/homebrew-dart#54.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md

@jslee02 jslee02 added this to the DART 6.6.1 milestone Aug 5, 2018
@jslee02 jslee02 requested a review from mxgrey August 5, 2018 19:24
@jslee02 jslee02 changed the title Use env variable to search DART data files in DartResourceRetriever Add option to DartResourceRetriever to search from environment variable DART_DATA_PATH Aug 5, 2018
@codecov
Copy link

codecov bot commented Aug 5, 2018

Codecov Report

Merging #1095 into release-6.6 will increase coverage by 0.02%.
The diff coverage is 93.75%.

@@               Coverage Diff               @@
##           release-6.6    #1095      +/-   ##
===============================================
+ Coverage        56.59%   56.61%   +0.02%     
===============================================
  Files              320      320              
  Lines            24524    24539      +15     
===============================================
+ Hits             13879    13893      +14     
- Misses           10645    10646       +1
Impacted Files Coverage Δ
dart/utils/DartResourceRetriever.hpp 100% <100%> (ø) ⬆️
dart/utils/DartResourceRetriever.cpp 89.33% <93.33%> (+1%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants