Add option to DartResourceRetriever to search from environment variable DART_DATA_PATH #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fallback option to
DartResourceRetriever
to use an environment variable to search DART data files. The existing preprocessor,DART_DATA_GLOBAL_PATH
, doesn't work if the package manager uses temporary install directory (e.g., Launchpad PPA and Homebrew).This should resolve #1091 and dartsim/homebrew-dart#54.
Before creating a pull request
clang-format
Before merging a pull request
CHANGELOG.md