Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking file existence in DartResourceRetriever #1107

Merged
merged 3 commits into from
Sep 3, 2018

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 31, 2018


Before creating a pull request

  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 changed the title Fix file existence logic in DartResourceRetriever Fix checking file existence in DartResourceRetriever Sep 3, 2018
@jslee02 jslee02 added this to the DART 6.6.2 milestone Sep 3, 2018
@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #1107 into release-6.6 will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           release-6.6    #1107   +/-   ##
============================================
  Coverage        56.61%   56.61%           
============================================
  Files              320      320           
  Lines            24539    24539           
============================================
  Hits             13893    13893           
  Misses           10646    10646
Impacted Files Coverage Δ
dart/utils/DartResourceRetriever.cpp 89.33% <100%> (ø) ⬆️

@jslee02 jslee02 merged commit 4fdbfbb into release-6.6 Sep 3, 2018
@jslee02 jslee02 deleted the fix/dart_rss_retriever branch September 3, 2018 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant