Add Metaskeleton::cloneMetaSkeleton() #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next: * Simplify clone functions utilizing Linkage only requires one skeleton clone
mxgrey
previously approved these changes
Dec 10, 2018
dart/dynamics/MetaSkeleton.hpp
Outdated
| const std::string& cloneName) const = 0; | ||
| // TODO: In DART7, rename this to clone() and change the current | ||
| // Skeleton::clone() to override it. Then consider adding | ||
| // Skeleton::cloneSkeleton(). |
There was a problem hiding this comment.
Super nitpick: We don't need to consider adding Skeleont::cloneSkeleton(), because it's already been added.
Codecov Report
@@ Coverage Diff @@
## release-6.7 #1201 +/- ##
===============================================
+ Coverage 56.59% 56.65% +0.06%
===============================================
Files 346 346
Lines 25658 25812 +154
===============================================
+ Hits 14520 14625 +105
- Misses 11138 11187 +49
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces clone functions to MetaSkeleton classes. It basically clones necessary
Skeletons are held by a MetaSkeleton as needed.The clone function name of MetaSkeleton is
cloneMetaSkeleton()to avoid the name conflict withSkeleton::clone().Before creating a pull request
clang-formatBefore merging a pull request
CHANGELOG.md