Unreliable plane-mesh collision detection #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest merging this tests as disabled tests to have this tests compiled sussessfully with future changes. |
|
Good idea! I've added the |
mxgrey
changed the title
jslee02
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only for illustrative purposes. We can go ahead and decline it whenever. I just wanted to present a test that illustrates the findings that I reported in #1234.
I've noticed that the ODE collision detector can have totally inconsistent results in between tests, and the results also seem to be very sensitive to the order in which the tests are run (e.g. if you change the order of the some of the elements in the for-loops, the results can be dramatically different). This makes me suspect that there's some very serious undefined behavior occurring, either in our ODE wrapper or in ODE itself.