Use GNUInstallDirs for lib/include path #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jslee02
requested changes
Feb 13, 2019
There was a problem hiding this comment.
Looks great to me! I have one request though. Could you retarget this to release-6.8, which is the active development branch? master branch is for DART 7.0 that will take some time to be released.
I think we should create release-7.0 from current master and make an active development branch (i.e., release-6.8 for now) as master to avoid these confusion. Let me do this once your PRs are merged.
|
follow in #1241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change uses
GNUInstallDirscmake module to provide platform specific paths. Not sure how this can affect how Dart manages the directory structure on Windows.