Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #1243 and add a regression test #1244

Closed
wants to merge 3 commits into from
Closed

Conversation

mxgrey
Copy link
Member

@mxgrey mxgrey commented Feb 19, 2019

This fixes the problem reported in #1243.

I'll also open PRs to patch this in earlier releases of 6.x, because it's a very significant error (even though the fix is very simple).

jslee02 pushed a commit that referenced this pull request Feb 20, 2019
Same as #1244 but targeting release-6.7 for a patch release.
@jslee02
Copy link
Member

jslee02 commented Feb 21, 2019

#1245 is merged to release-6.7. Let's apply the patch to master by merging release-6.7 into master. I think we don't need to have duplicate changelog item for the same patch. Closing in favor of #1249.

@jslee02 jslee02 closed this Feb 21, 2019
@jslee02 jslee02 deleted the grey/fix_1243 branch January 10, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants