Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect transpose check in Inertia::verifySpatialTensor() #1258

Merged
merged 5 commits into from
Mar 7, 2019
Merged

Fix incorrect transpose check in Inertia::verifySpatialTensor() #1258

merged 5 commits into from
Mar 7, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Mar 2, 2019 •
edited
Loading

The last check of Inertia::verifySpatialTensor() doesn't correctly test the transpose relationship of the top-right block and the bottom-left block.

Resolves #1257

Before creating a pull request

  • Document new methods and classes (N/A)
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 requested a review from mxgrey March 2, 2019 10:31
@jslee02 jslee02 marked this pull request as ready for review March 2, 2019 10:33
@jslee02 jslee02 added this to the DART 6.8.0 milestone Mar 2, 2019
@jslee02 jslee02 merged commit 5d78f93 into master Mar 7, 2019
@jslee02 jslee02 deleted the fix_tensor_check branch March 7, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
DART 6.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jslee02