Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples directory to make dart::gui::osg more accessible #1305

Merged
merged 8 commits into from
May 6, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 4, 2019

This PR tweaks the examples directory to make dart::gui::osg more accessible. Following changes are also made:

  • Change example and tutorial directory names to all lower cases
  • Remove InSourceBuild.cmake files in favor of dart_build[_example/_tutorial]_in_source() macros
  • Format examples and tutorials code
  • Add hello_world example

Resolves #1304


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 4, 2019
@jslee02 jslee02 requested a review from mxgrey May 4, 2019 11:43
@jslee02 jslee02 changed the title Examples tutorials Update examples directory to make dart::gui::osg more accessible May 4, 2019
@jslee02 jslee02 marked this pull request as ready for review May 4, 2019 11:47
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #1305 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
+ Coverage    57.1%   57.11%   +0.01%     
==========================================
  Files         363      363              
  Lines       26954    26954              
==========================================
+ Hits        15392    15395       +3     
+ Misses      11562    11559       -3
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.12% <0%> (+0.16%) ⬆️

@jslee02 jslee02 merged commit 84adcfa into master May 6, 2019
@jslee02 jslee02 deleted the examples_tutorials branch May 6, 2019 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Tweak the examples directory to make dart::gui::osg more accessible
1 participant